Add navigation overlay block #55548
Closed
Add navigation overlay block #55548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/blocks.php |
|
Size Change: -337 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 1e609fb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6625162703
|
|
I love this concept, and it would help me offload stuff in style.css in various themes. |
scruffian
added
[Block] Navigation
scruffian
requested review from
spacedmonkey,
tellthemachines,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
scruffian
commented
Oct 24, 2023
| @@ -31,6 +31,7 @@ function gutenberg_reregister_core_block_types() { | |||
| 'media-text', | |||
| 'missing', | |||
| 'more', | |||
| 'navigation-overlay', | |||
There was a problem hiding this comment.
This is needed so that Global Styles outputs the styles
|
This isn't working correctly, as the block itself isn't being output, so the CSS from Global Styles is never enqueued.... |
|
Perhaps this effort should be considered as an experiment? I'm not 100% certain is this is the direction to take yet, but it's certainly worth exploring. |
|
I don't think we'll need this now... |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a block that wraps the navigation overlay.
Why?
This will be useful for two reasons:
How?
Creates a new block called Navigation Overlay, which is used as the navigation overlay.
Testing Instructions